Helm chart improvements including allowing user password to be pulled from K8s secret #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
min_pool_size
andsever_lifetime
configurable under the user section.Why
server_lifetime
gets overwritten by the hardcodedserver_lifetime
value under the user section, which can cause confusion. So, if it is not explicitly set in thevalues.yaml
, it should not be set per user at all, and the global value should be respected.min_pool_size
should also be configurable and if not set the default value will be3
as per the original version of the chart.server_tls = true
.statement_timeout
has default value of 0 and should be explicitly enabled.