-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only log warnings #244
Only log warnings #244
Conversation
The failing test is caused by #123. |
From https://github.com/postcss/postcss-reporter#purpose:
Isn't this actually working this way? |
Not for me at least. postcss-reporter is, as far as I can tell, only used for formatting the messages: Line 15 in af81c55
The reason I submitted the PR was that I am seeing all of the dependency messages printed as I was kinda hyper focused yesterday, so I realise now that opening an issue and actually describing the situation would have been clearer, sorry about that :/ |
Tests are failing because you didn't run |
Currently messages are only logged if there are warnings, but if there are then all messages are logged.
Sorry for the super late reply to this, and for my overall sloppiness with the PR 😕 When I run However, if I change the I have updated the PR with a properly formatted patch, so now everything should be OK, but you might want to be aware of the prettier issue I encountered. |
@stefanfisk What's your OS? |
@RyanZim macOS Mojave. I am running zsh, but as far as I can remember the issue was reproducible when I switched to Bash. Quoting the glob also worked if I remember correctly, but I have not investigated how exactly npm executes the scripts and what the implications of not quoting are. |
Ah, makes sense. Globstar ( Will fix. |
Coinsidentally I tried to fix the same issue from the Thanks to both of you! |
@RyanZim this causes empty lines printed. https://travis-ci.org/twbs/bootstrap/jobs/475278409#L666-L695 |
@XhmikosR what have done to verify that this change is the cause of the blank lines? |
Obviously I tested it. |
Currently messages are only logged if there are warnings, but if there are then all messages are logged.