Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Secrets view and deploy with Secrets to extension #2288
Add Secrets view and deploy with Secrets to extension #2288
Changes from 16 commits
006dbf6
78e8cc7
c5de584
393bfc9
e7b4279
2ef1975
06f3220
8895901
fff20db
1ecc282
399b651
48c1d6a
13a711a
26c8c83
55d5b0d
723dd4f
45e5056
9dd300b
144b185
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to bring in flex for the label container so that the input in the description
span
could be displayed the way we want. This required bringing down theCSS for dealing with overflowing with ellipsis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line-height
has returned. Now that we are usingdisplay: flex
here thespan
is no longer being rendered the same way. Without this the height changes, and the description wasn't on the baseline.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
description
can contain aninput
now we don't want the description to always beopacity: 0.7
. Now we apply this only if the description doesn't contain aninput
(see below)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This retains the behavior we had before where the description would shrink before the title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected that this component would be a UI component that would accept its name and value through a prop and emit a change when the value changed. I would then have expected the view using this component to have to deal with the storage of the secret value.
While this approach will work, it makes this component extremely dedicated to this particular input vs. having a component that allows its value to be edited. I think we would benefit from having it be a bit more general purpose, especially when you think of using it for environment variables as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually started writing it this way at the start, but found it more difficult to keep the
home.secrets
Map in line with the value that was beingv-model
ed inSecret.vue
instead I made it just reflect the state ofhome.secrets.get('name')
for thename
key providedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main difficulty when using
v-model
was grabbing the most recent value when swapping over to the input mode. It worked great when setting the value, but not when the value changed out from under the component.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you get a chance to play with the approach we discussed via zoom? That would be where outside component would pass in the map value from the store and then update the store when receiving the change emitted event from the component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did mess around with this, and it ended up re-creating the Map in the
Secrets
component a bit as an array so eachv-model
accessed an index in that array. It felt duplicative to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could optionally show this only if 1 or more secrets have values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more I use this the more I want to do this, since the button moves if the count badge is showing or not.