Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware manager page is blank when the system is offline #28

Closed
brs17 opened this issue Aug 2, 2019 · 1 comment
Closed

Firmware manager page is blank when the system is offline #28

brs17 opened this issue Aug 2, 2019 · 1 comment

Comments

@brs17
Copy link

brs17 commented Aug 2, 2019

When there is no network connection, currently an error appears error trying to connect.

When a system is offline and not connected to a network, this page should still be able to show the currently installed firmware (just not be able to check for updates).

@brs17
Copy link
Author

brs17 commented Aug 2, 2019

I'm wondering, what errors could we get from system76-firmware that we would want to show to the user? Potentially we just handle errors where we want to change the displayed output and ignore other ones?

Example thoughts:
Error 1: No network connection
Workaround A: Ignore error, show currently installed firmware
Workaround B: Show currently installed firmware, provide some sort of message that a network connection is necessary for searching for firmware updates

Error 2: error calling the download method, which provides the changelogs
Workaround A: When the error is received, display Changelog missing or something to that extent. Would part of the Changelog missing message want to include something about how there is an error?
Workaround B: Leave changelog blank.

Other than not having a network connection (and errors gathered from that), I am not sure what value an error could provide a user.

Thoughts on how to deal with errors @WatchMkr / @mmstick / @jackpot51 ?

@mmstick mmstick closed this as completed in 2e5e903 Aug 5, 2019
mmstick added a commit that referenced this issue Aug 13, 2019
If a network connection cannot be stablished to fetch firmware changelogs, we will instead display the devices with or without those changelogs

Fixes #28
mmstick added a commit that referenced this issue Aug 13, 2019
If a network connection cannot be stablished to fetch firmware changelogs, we will instead display the devices with or without those changelogs

Fixes #28
mmstick added a commit that referenced this issue Aug 13, 2019
If a network connection cannot be stablished to fetch firmware changelogs, we will instead display the devices with or without those changelogs

Fixes #28
mmstick added a commit that referenced this issue Aug 13, 2019
If a network connection cannot be stablished to fetch firmware changelogs, we will instead display the devices with or without those changelogs

Fixes #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant