-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json parsing improvements & fixes #58
json parsing improvements & fixes #58
Conversation
added a fix, but it's non-trivial as we have to manage a bit more state than just "what's next?" in a stack - the "have we done the first one?" needs to be preserved across stack frames will do some testing with more round-trips using ipld-garbage to see if this breaks anywhere interesting where it shouldn't |
(lgtm) |
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
ipld/go-ipld-prime#550 looks good, I feel more confident about these changes now |
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
Per @rvagg 's nudge in another channel that you're happy with this now -- I'm also perfectly happy to merge this, and thank you :) |
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
This isn't a fix, it's just a placeholder (demonstration) of some cases that should fail that don't and some that fail with errors messages that are inappropriate. Posting this here while I notice it, perhaps I'll come back and fix soon!More tests added; fixes applied; more comprehensive testing done via ipld/go-ipld-prime#550