-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add car and car generator #102
Conversation
@rvagg does import work for you? Kubo 0.24 gives me: $ ipfs dag import --pin-roots=false tmp/fixtures.car
Error: import failed at block "bafyreieir43khjzemsmgahaozab2vjvtdxavszixhhurvdqg2xkhrwinyi": cbor: negative integer out of rage of int64 type |
Ah yeah, I forgot about the Go special cases, they're listed here: https://github.com/ipld/codec-fixtures/blob/master/go/special_cases.go Some extra details about the uint64 / int64 boundary in Go are here: ipld/go-ipld-prime#413 (also see notes in the tests in there), mostly large >int64 values should be parseable (aside from the faulty I'm not sure exactly which problem Kubo will be encountering here, it could simply be the Works in the JS stack though, and therefore web3.storage. Maybe this needs a caveat in the README. |
ah, more details:
First one is out, regardless, it's negative max uint64, which isn't a thing in Go. I did have an early proposal in ipld/go-ipld-prime#413 to return a negative indicator that could deal with this, but the complexity made it not worth it. The other two failures are dag-json strconv failures. They could potentially be fixed, but are low priority, and I already have other json fixes in play that I can't get over the line (polydawn/refmt#58, not that I've pushed very hard on that). |
Thanks! A bit unfortunate edge cases, I've filled ipfs/kubo#10236 for tracking follow-up work in Kubo, but yeah, lower priority until this impacts real world use case. |
this reminded me to ping about getting polydawn/refmt#58 merged and that's done now so I should update for that at least; I don't doubt that if we cared enough the json things are entirely fixable. Negative uint64 for Go is a bit more iffy though. |
also updated deps, and published the current CAR to web3.storage so they're available on ipfs, e.g.: https://ipfs.io/ipfs/bafyreidhjbzws7yyooefukqt4xvbrctkz5pj5c7dnhdea6nepemymhkccm/