Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funcky.XUnit is not compatible with the XUnit 2.5 and 2.6 releases. #777

Closed
FreeApophis opened this issue Dec 22, 2023 · 3 comments · Fixed by #788
Closed

Funcky.XUnit is not compatible with the XUnit 2.5 and 2.6 releases. #777

FreeApophis opened this issue Dec 22, 2023 · 3 comments · Fixed by #788

Comments

@FreeApophis
Copy link
Member

FreeApophis commented Dec 22, 2023 •
edited
Loading

XUnit has breaking changes in each of the releases. Since we do declare falsley that they are compatbile this results in some very nasty exceptions on executing the tests:

System.TypeLoadException : Could not load type 'Xunit.Sdk.AssertActualExpectedException' from assembly 'xunit.assert, Version=2.6.3.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c'.

The problem is that we assume that XUnit has a Semantic Versioning, while they explicitly state that they have a different versioning system: "You cannot make a SemVer-based assumption about the scope of changes based on the version."
@FreeApophis FreeApophis changed the title Funcky.XUnit is not compatible with the 2.5 and 2.6 releases. Funcky.XUnit is not compatible with the XUnit 2.5 and 2.6 releases. Dec 22, 2023
FreeApophis added a commit that referenced this issue Dec 22, 2023
@FreeApophis
Declarte Funcky.XUnit incompatibility with xunit 2.5 and 2.6 releases…
091ac85 
…: see #777
@FreeApophis
Copy link
Member Author

FreeApophis commented Dec 22, 2023 •
edited
Loading

We should merge #778 to declares this correctly for now.

We should also support current xUnit releases later.

@FreeApophis FreeApophis mentioned this issue Dec 22, 2023
Merged
@bash
Copy link
Member

bash commented Dec 22, 2023

Should we do a release of Funcky.Xunit?

@FreeApophis
Copy link
Member Author

I thought we release together with the next Funcky release.

@FreeApophis FreeApophis linked a pull request Apr 29, 2024 that will close this issue
Release Commit for Funcky 3.4 and Funcky Async 1.3 #788
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release Commit for Funcky 3.4 and Funcky Async 1.3 polyadic/funcky
2 participants
@FreeApophis @bash