Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transfer button disappearance #10081

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

pacoyang
Copy link
Contributor

@pacoyang pacoyang commented Dec 6, 2023

Removed transfer call in polkadot v1.2 causing the transfer button disappearance.
See: https://github.com/paritytech/polkadot-sdk/pull/1226/files#diff-5dfe6adcc3c44280fc10cd49830df408a491c768a54f47835d822a0d1334d385L737

This bug causes the transfer button to be missing on chains upgraded to Polkadot ^1.2.0, like Phala.

@jasl
Copy link
Contributor

jasl commented Dec 8, 2023

I guess we need to test transferAllowDeath exists first, if not found, then fallback to transfer?

@jasl
Copy link
Contributor

jasl commented Dec 8, 2023

@jacogr this also affects Rococo, could you help to take a look?

@pacoyang
Copy link
Contributor Author

pacoyang commented Dec 8, 2023

I guess we need to test transferAllowDeath exists first, if not found, then fallback to transfer?

Fixed.

@jasl
Copy link
Contributor

jasl commented Dec 11, 2023

@jacogr friendly ping

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@jacogr jacogr merged commit 1f0d910 into polkadot-js:master Dec 12, 2023
5 checks passed
@pacoyang pacoyang deleted the fix-missing-transfer-button branch December 13, 2023 01:44
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants