Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [Collectives] Add TX payment extension #442

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 23, 2024

🚨 Breaking Change 🚨

  • This adds a signed extension for the polkadot-collectives runtime which will break transaction encoding.

Status: waiting for #445

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review August 23, 2024 08:51
@ggwpez
Copy link
Member Author

ggwpez commented Aug 23, 2024

/merge

@joepetrowski
Copy link
Contributor

@Imod7 @SBalaguer @anaelleltd please notify wallets, this will be a breaking change for transaction encoding.

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) August 23, 2024 10:44
@joepetrowski joepetrowski mentioned this pull request Aug 23, 2024
3 tasks
@kianenigma
Copy link
Contributor

/merge cancel

@kianenigma
Copy link
Contributor

/merge

@fellowship-merge-bot
Copy link
Contributor

Disabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@anaelleltd
Copy link
Collaborator

The author of a PR that introduces a breaking change should:

  • recommend a course of action for builders/teams to follow up
  • highlight the nature of this breaking change more prominently in the CHANGELOG

The rationale for these additional steps is available here.

@ggwpez ggwpez changed the title [Collectives] Add TX payment extension 🚨 [Collectives] Add TX payment extension Aug 26, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr
Copy link
Contributor

bkchr commented Aug 26, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) August 26, 2024 15:39
@fellowship-merge-bot fellowship-merge-bot bot merged commit 24df7e1 into main Aug 26, 2024
34 of 47 checks passed
@ggwpez ggwpez deleted the oty-tx-payment branch August 26, 2024 17:41
fellowship-merge-bot bot pushed a commit that referenced this pull request Aug 26, 2024
to be merged as part of 1.3.1 after
#442

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants