Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 Release #186

Closed
9 tasks done
bkontur opened this issue Feb 14, 2024 · 23 comments · Fixed by #438
Closed
9 tasks done

1.3.0 Release #186

bkontur opened this issue Feb 14, 2024 · 23 comments · Fixed by #438

Comments

@bkontur
Copy link
Contributor

bkontur commented Feb 14, 2024

TODO for removing older stuff

@bkontur bkontur changed the title Remove DMPQueue with 1.3.0 release Removals 1.3.0 release Feb 16, 2024
@bkontur bkontur changed the title Removals 1.3.0 release 1.3.0 Release Feb 16, 2024
bkontur added a commit to bkontur/runtimes that referenced this issue Feb 29, 2024
fellowship-merge-bot bot pushed a commit that referenced this issue Mar 24, 2024
##TODO 

<!-- Remember that you can run `/merge` to enable auto-merge in the PR
-->

<!-- Remember to modify the changelog. If you don't need to modify it,
you can check the following box.
Instead, if you have already modified it, simply delete the following
line. -->

- [x] Does not require a CHANGELOG entry
- [x] create tracking issue for adding `uri` to the
`runtimes-matrix.json` when deployed live - as a part of
#186
- [x] regenerate weights
@bkchr
Copy link
Contributor

bkchr commented Mar 25, 2024

@eskimor
Copy link
Contributor

eskimor commented Mar 27, 2024

  • Make sure this gets in. Either by using upcoming polkadot-sdk 1.10.0 or backporting 3714.

@bkchr
Copy link
Contributor

bkchr commented Apr 6, 2024

  • Coretime, depending on how the migration works on Kusama

@joepetrowski
Copy link
Contributor

joepetrowski commented Apr 10, 2024

@rossbulat
Copy link
Contributor

I've noticed pallet-staking has been bumped to 29.0.2 in the workspace, but just wanted to check paritytech/polkadot-sdk#2589 will be deployed in 1.3.0 as to move forward with controller account deprecation.

@s0me0ne-unkn0wn
Copy link
Contributor

s0me0ne-unkn0wn commented Apr 19, 2024

@brenzi
Copy link
Contributor

brenzi commented Apr 30, 2024

@eskimor
Copy link
Contributor

eskimor commented Jun 6, 2024

What is the current plan for this release. Like with what node release do we want to cut this one?

For Coretime we need node 1.14 for Polkadot (the one after the one that is currently being cut). Do we want to wait for that or do we want to cut a release earlier already?

@joepetrowski
Copy link
Contributor

joepetrowski commented Jun 25, 2024

@the-right-joyce
Copy link

the-right-joyce commented Jul 16, 2024

  • Include migration for all existing parachains to coretime

@bkchr
Copy link
Contributor

bkchr commented Jul 16, 2024

  • Add Integritee's lease to the coretime migration

@the-right-joyce is there more information on this?

@joepetrowski
Copy link
Contributor

^I think we should just change it to, "Include migration for all existing parachains to coretime"

@SBalaguer
Copy link
Contributor

  • Add Integritee's lease to the coretime migration

@the-right-joyce is there more information on this?

@bkchr the biggest problem is that the current auction model allows for chains to have 'future' leases (a.k.a. a lease that starts sometime in the future) and the new coretime model does not (a.k.a. teams can't have a core that starts in the future, it needs to start now and for a given amount of time). Therefore we need to find a solution to make these two things work.

If the migration takes a snapshot of the system at a given point in time, it will find:

  • Parachains that currently hold a slot for a given amount of time.
  • Parachains that don't have a slot currently and have one starting sometime in the future. This future can be anything from the immediate next lease period, up to 7 lease periods in the future (~1y).

What I would suggest then, is to compromise on giving a core to every team that either currently has a slot now, or that has a slot starting in the upcoming lease period. From my point of view, migrating this way would make it more compatible with the current auctions happening on Polkadot. This would mean giving 'free coretime' to the teams that start in the upcoming lease period (which with current estimates of launch is ~1mo).

Example: Integritee
Integritee has been a parachain on Polkadot since August 2022 when they won auction #23, which gave them a slot that expired on LP17. Unfortunately, this team didn't manage to secure an auction that would allow them to have a slot for LP17, yet they did win auction 69 that granted them a lease for LP18-24.

If the migration of coretime happens anytime during LP17 (as it's expected) and it only considers teams holding a lease, then Integritee would be left without a core. However, if we pursue a migration as I'm suggesting by which every team that has a slot now, or has one starting on LP18 gets a core, then Integritee would be having a core.

Open Questions
The biggest item to discuss potentially on this is load (i.e.: having more cores allocated in the future than the current amount of slots). I don't see this as a potentially big issue as the new teams that win an auction in the current set of auctions would replace those that don't manage to extend their lease, but might be worth it to double-check the numbers.

@eskimor
Copy link
Contributor

eskimor commented Jul 24, 2024

  • Enable Coretime on the relay chain

@bkchr
Copy link
Contributor

bkchr commented Jul 25, 2024

@bkchr the biggest problem is that the current auction model allows for chains to have 'future' leases (a.k.a. a lease that starts sometime in the future) and the new coretime model does not (a.k.a. teams can't have a core that starts in the future, it needs to start now and for a given amount of time). Therefore we need to find a solution to make these two things work.

I would have thought we do the same as on Kusama? Everyone that hasn't an active lease, gets the lease returned and the locked funds are free. They are then able to buy the core on the open market.

@brenzi
Copy link
Contributor

brenzi commented Jul 25, 2024

@bkchr I'm obviously biased here, but Integritee has won an auction at a certain price for a range of lease periods. What you suggest is breaking this "contract", leaving Integritee worse off (just to avoid technical extra work by the fellowship for the migration). Kusama had no similar case AFAIK.

Let me just suggest the most simple possible solution: Grant Integritee a few weeks of coretime ahead of their official lease LP18 and save a lot of hassle (migrate as if it was active in LP17). With all the usual delays to be expected, this will make very little difference for anyone. Integritee's DOT are locked already anyway.

@eskimor
Copy link
Contributor

eskimor commented Jul 25, 2024

@brenzi I am looking into it, but to explain the reasoning: The original assumption was, that if a lease has not yet started, then we are also not causing any liveness issues, so refunding and going directly with Coretime should be acceptable and seemed like the fairest solution at the time. (E.g. otherwise people could buy part time leases on purpose to get free coretime.) Also we might end up with significantly more cores than what we planned to support.

@seadanda
Copy link
Contributor

seadanda commented Aug 6, 2024

@eskimor
Copy link
Contributor

eskimor commented Aug 8, 2024

  • Run benchmarks
  • Final tests (with finalized weights)

@skunert
Copy link
Contributor

skunert commented Aug 8, 2024

This should go in too: #423

fellowship-merge-bot bot pushed a commit that referenced this issue Aug 12, 2024
Relates to: #186

<!-- Remember that you can run `/merge` to enable auto-merge in the PR
-->

<!-- Remember to modify the changelog. If you don't need to modify it,
you can check the following box.
Instead, if you have already modified it, simply delete the following
line. -->

- [X] Does not require a CHANGELOG entry
@olanod
Copy link
Contributor

olanod commented Aug 16, 2024

It would be nice to get this small Kusama addition #430

@joepetrowski
Copy link
Contributor

It would be nice to get this small Kusama addition #430

It was merged so it is in.

@seadanda seadanda mentioned this issue Aug 16, 2024
3 tasks
fellowship-merge-bot bot added a commit that referenced this issue Aug 20, 2024
Trigger the v1.3.0 release with the following additional changes:

- Bump `polkadot-runtime-parachains` version to get
paritytech/polkadot-sdk#5369 in
[63cb34d](63cb34d)
and update tests in
[e718c64](e718c64).
- Filter calls to `interlace` on the Polkadot Coretime Chain until the
relay implementation matures in
[1126cf7](1126cf7).
- Update all runtime versions to `1_003_000` in
[08744df](08744df)

TODO:
- [x] Finalise changelog
- [x] Wait for #433
- [x] Wait for #364

Closes #186

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.