Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 (Android Plugin) Support #220

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

atlasapplications
Copy link

This adds v2 support for the new Android Plugin architecture that is compatible with Godot 4.2+ going forward.

This adds v2 support for the new Android Plugin architecture that is compatible with Godot 4.2+ going forward.
Fixed paths that point to the output binaries.
Needed to add remote and local dependencies instead of separate configuration files. Added plugin file for GDScript users. Upgraded Gradle to newer version.
The wrong method was overridden and has been corrected. Successfully tested using C#.
@gumaciel
Copy link
Contributor

gumaciel commented May 4, 2024

thank you very much for the PR, we will test it soon

@rogerlopz
Copy link

Any updates on this? The current plugin works fine but it would be nice to have the new plugin architecture

@gumaciel
Copy link
Contributor

@rogerlopz I'll try to review and merge this PR this weekend

@TheSkyOne
Copy link

Hello! can I ask where is this standing? I am using godot 4.2 and when I build to android I get error "PoingGodotAdMob not found, make sure you marked all 'PoingAdMob' plugins on export tab"
But of-course it is no longer possible to do so in 4.2 or higher...

@TheSkyOne
Copy link

Are there any plans on testing and merging this any time soon?
if not, @atlasapplications would you mind providing instructions on how to build and use the plugin with your updates?

@gumaciel
Copy link
Contributor

gumaciel commented Sep 1, 2024

@TheSkyOne I'm working on this right now.

You can still use the plugin v1 on Godot 4.2 or higher, for that you need to:

  • Create a folder "plugins".
  • Paste the files like this:
    Screenshot 2024-09-01 at 18 57 54
  • Only paste the files that you need to, if you don't need the mediations, then don't paste

@TheSkyOne
Copy link

Thank you for updating. I am OK with waiting until you update the plugin to V2, just wanted to know if it was in the works.
Thank you for you work on the plugin!

@gumaciel gumaciel linked an issue Sep 4, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Upgrade to Android v2
4 participants