Skip to content

Commit

Permalink
pmem-csi-driver: remove redundant driver mode check
Browse files Browse the repository at this point in the history
User input is already checked in DriverMode.Set, therefore we can
assume that all DriverMode strings are valid.
  • Loading branch information
pohly committed Nov 9, 2020
1 parent 62b865e commit 981e053
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions pkg/pmem-csi-driver/pmem-csi-driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,17 +207,10 @@ func (dm deviceManagerCollector) Collect(ch chan<- prometheus.Metric) {
var _ prometheus.Collector = deviceManagerCollector{}

func GetCSIDriver(cfg Config) (*csiDriver, error) {
validModes := map[DriverMode]struct{}{
Controller: struct{}{},
Node: struct{}{},
}
var serverConfig *tls.Config
var clientConfig *tls.Config
var err error

if _, ok := validModes[cfg.Mode]; !ok {
return nil, fmt.Errorf("Invalid driver mode: %s", string(cfg.Mode))
}
if cfg.DriverName == "" {
return nil, errors.New("driver name configuration option missing")
}
Expand Down

0 comments on commit 981e053

Please sign in to comment.