Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow container ref with null and undefined for useResize #2091

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix: allow container ref with null and undefined for useResize #2091

merged 1 commit into from
Mar 17, 2023

Conversation

floriangosse
Copy link
Contributor

Why

Allow to pass nullish container references to useResize.

What

Extended type of useResize to allow null and undefined as reference value types as well.

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2023

⚠️ No Changeset found

Latest commit: 54dc175

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-spring ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 7:22PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54dc175:

Sandbox Source
Animating Auto Configuration
Card Configuration
Cards Stack Configuration
Chaining Transition and a Spring Configuration
CSS Gradients Configuration
CSS Keyframes Configuration
Async CSS variables Configuration
Draggable List Configuration
Exit Before Enter Configuration
Flip Card Configuration
Floating Button Configuration
Goo Blobs Configuration
Image Fade Configuration
List Reordering Configuration
MacOS Dock Configuration
Masonry Grid Configuration
Multistage Transitions Configuration
Noise Configuration
Notification Hub Configuration
Horizontal Parallax Configuration
Sticky Parallax Configuration
Vertical Parallax Configuration
Rocket decay Configuration
Basic Transition Configuration
Native Slide Configuration

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Thank you 🙇🏼‍♀️

@joshuaellis joshuaellis merged commit 32c4b34 into pmndrs:main Mar 17, 2023
@floriangosse floriangosse deleted the use-resize-container-type branch March 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants