Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search options generation in CLI context #584

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

Mirkk
Copy link

@Mirkk Mirkk commented Oct 26, 2022

Fixes #428 Resolve error "Undefined index: glpiactiveprofile" when using the fields plugin from a cron (automaticAction) job.

…en using the fields plugin from a cron (automaticAction) job.
@cedric-anne
Copy link
Contributor

cedric-anne commented Oct 27, 2022

Hi,
I fixed coding standard violations and change a bit your proposal to remove the JOIN clause that appears to be useless now. Could you check that it is still OK for you ?

@Mirkk
Copy link
Author

Mirkk commented Oct 27, 2022

Perfect, ok, thank you! Next time I'll try to use an IDE for formatting - I'm not a full time programmer, I'm just coding in editors...

@cedric-anne cedric-anne changed the title Resolve issue #428 "Undefined index: glpiactiveprofile" when using th… Fix search options generation in CLI context Oct 27, 2022
@cedric-anne cedric-anne added this to the 1.18.2 milestone Oct 27, 2022
@cedric-anne cedric-anne merged commit dce3d6c into pluginsGLPI:develop Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields Plugin can not be configured as automatic action due to active profile check
2 participants