Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncated double error in new item forms #533

Merged

Conversation

cconard96
Copy link
Contributor

Without type restrictions on itemtype fields, an empty string is sometimes used for new items and should not be passed into a SQL query as an empty string in a condition on a numeric field will yield a "Truncated incorrect DOUBLE value" error/warning.

@cconard96 cconard96 added the bug label Jun 7, 2022
@cedric-anne cedric-anne changed the base branch from master to develop June 10, 2022 10:52
@cedric-anne
Copy link
Contributor

Can you explain how to reproduce the issue ?

@cconard96
Copy link
Contributor Author

Create block with a field (I used a yes/no dropdown and computer item dropdown) for the main form of tickets.
Open new ticket form in self-service.
See debug notice at bottom above the first field.

@cedric-anne cedric-anne added this to the 1.15.4 milestone Jun 10, 2022
@cedric-anne cedric-anne merged commit 79b92b6 into pluginsGLPI:develop Jun 10, 2022
@cedric-anne cedric-anne modified the milestones: 1.15.4, 1.16.0 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants