Fix files regeneration during install #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During install process, all plugin files were dropped, but none were regenerated, as plugin cannot be active when it is not yet installed.
After a quick analysis, I figured out that files were already regenerated by
PluginFieldsContainer::install()andPluginFieldsDropdown::install(), so I removed call toplugin_fields_checkFiles()during install process.I also simplified
plugin_fields_checkFiles()which is always called with$force=truenow. Appropriate session/rights checks are done before calling this method, so there is no need to have checks on session inside it.