-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial v5 migration #126
Conversation
package.json
Outdated
@@ -57,10 +58,9 @@ | |||
"@strapi/strapi": "^4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this to be the beta, and also add it to your devDeps, this is typically how peer-deps work, that should solve the lint issue above where it can't find the types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed to have fixed the issue I mentioned on Discord. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review @joshuaellis.
I'm able to continue with the migration now.
Just a note, as you saw, eslint threw an error due to import/no-unresolved
.
This is actually a rule that comes from eslint-config-airbnb
, which is a fairly popular eslint config set.
This seems to be because of the package.json
exports field not being respected in that eslint rule.
And from the looks of it, they're not planning to support that. Source: airbnb/javascript#2853
For now I've just added the @strapi
packages to the ignore list of that eslint rule.
Though I still though you should know. Maby this'll pop up some more places down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmu in discord if you find any other issues and I'll try get back to you. RE Airbnb config, thanks for highlighting.
No description provided.