Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Add plural translation to %s seconds #52

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

pedro-mendonca
Copy link
Contributor

Add support for singular/plural to the duration column info %s second / %s seconds.

Copy link
Contributor

@stklcode stklcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro. Looks good and works as expected.

I'd guess singular second should be a pretty rare case here, but the change is totally reasonable.

@stklcode stklcode merged commit ce33ab7 into pluginkollektiv:master Nov 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants