Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of example in interactive-html-export.md #4478

Closed
wants to merge 1 commit into from

Conversation

Arcader717
Copy link

@Arcader717 Arcader717 commented Jan 9, 2024

Should fix the rendering of the python example. The html example still isn't rendering correctly. Basically just a typo fix

Documentation PR

The example in line 75-92 did not display correctly in documentation. Added the python keyword to the render
@Arcader717 Arcader717 changed the title Update interactive-html-export.md Fix rendering of interactive-html-export.md Jan 9, 2024
@Arcader717 Arcader717 changed the title Fix rendering of interactive-html-export.md Fix rendering of example interactive-html-export.md Jan 9, 2024
@Arcader717 Arcader717 changed the title Fix rendering of example interactive-html-export.md Fix rendering of example in interactive-html-export.md Jan 9, 2024
@Coding-with-Adam
Copy link
Contributor

Thank you for this PR, @Arcader717.
Could you please be more specific. Which rendering problem are you referring to?

@Arcader717
Copy link
Author

Thank you for this PR, @Arcader717.
Could you please be more specific. Which rendering problem are you referring to?

Sure. The python example is for using Django, but instead of rendering as a codeblock, the example renders as plain text. The PR should fix this problem

The html example mentioned in the sentence after refers to lines 62-71 in the same file. The issue is that the example renders as part of the html of the page

I hope this clarifies what I was referring to

@LiamConnors
Copy link
Member

Hi @Arcader717, thanks for the PR! I merged a fix last week to fix some rendering issues with that page
#4479 shortly after the original content was added. So your PR is to fix the same issue, I think. Does it render okay for you now on the page?

@Arcader717
Copy link
Author

Does it render okay for you now on the page?

Yes, thank you @LiamConnors

it renders correctly now

@Arcader717 Arcader717 closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants