Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

property x0shift, x1shift, y0shift, y1shift for adjusting the shape coordinates #7005

Merged
merged 26 commits into from
Jul 16, 2024
Merged

property x0shift, x1shift, y0shift, y1shift for adjusting the shape coordinates #7005

merged 26 commits into from
Jul 16, 2024

Commits on May 27, 2024

  1. property shape.x_shift/y_shift for adjusting the shape coordinates 

    Only for shapes with reference to (multi-)category axis
    @my-tien
    my-tien committed May 27, 2024
    Configuration menu
    Copy the full SHA
    aa0cd7a View commit details
    Browse the repository at this point in the history

  2. Add draftlog for PR 7005

    @my-tien
    my-tien committed May 27, 2024
    Configuration menu
    Copy the full SHA
    44d1858 View commit details
    Browse the repository at this point in the history

  3. Add x_shift/y_shift for selections as well, add selection example to … 

    …mock
    @my-tien
    my-tien committed May 27, 2024
    Configuration menu
    Copy the full SHA
    7abea61 View commit details
    Browse the repository at this point in the history

  4. baseline images zzz_shape_shift_horizontal and zzz_shape_shift_vertical

    @my-tien
    my-tien committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a617017 View commit details
    Browse the repository at this point in the history

  5. Update shapes_test after adding shift param to getDataToPixel 

    If the passed shift param is undefined, use shift 0 instead.
    @my-tien
    my-tien committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c2f7f27 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Rename x_shift/y_shift → xshift/yshift

    @my-tien
    my-tien committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fdcaa0c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Replace xshift and yshift with x0shift and y0shift

    @my-tien
    my-tien committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9921522 View commit details
    Browse the repository at this point in the history

  2. Only coerce x0/x1/y0/y1shift if referenced axis is category/multicate… 

    …gory
    @my-tien
    my-tien committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3ac32f3 View commit details
    Browse the repository at this point in the history

  3. Fix typo in calc_autorange: x/ysizemode "scale" -> "scaled"

    @my-tien
    my-tien committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6680745 View commit details
    Browse the repository at this point in the history

  4. Add scatter to zzz_shape_shift_vertical mock

    @my-tien
    my-tien committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ada2289 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin-plotly/master' into shape_shift

    @my-tien
    my-tien committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e11f6f6 View commit details
    Browse the repository at this point in the history

  6. Updated baseline image after adding scatter to zzz_shape_shift_vertic… 

    …al_mock
    @my-tien
    my-tien committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1bfb22d View commit details
    Browse the repository at this point in the history

  7. getDataToPixel: If shift is undefined, set it to 0

    @my-tien
    my-tien committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    04466db View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Update draftlog with final property names

    @my-tien
    my-tien committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    91db7c8 View commit details
    Browse the repository at this point in the history

  2. Adjust attribute descriptions with property formatting and mention of… 

    … -0.5 and 0.5 for category start/end
    @my-tien
    my-tien committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    4bbb669 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Move calculation of shape shift into a dedicated function

    @my-tien
    my-tien committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ab935ac View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge remote-tracking branch 'origin-plotly/master' into shape_shift

    @my-tien
    my-tien committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    82de6b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Update overlooked test after changing xshift/yshift to x0shift,x1shif… 

    …t/y0shift,y1shift
    @my-tien
    my-tien committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f9c44bf View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Remove shift properties from selection for now

    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b00d4d8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin-plotly/master' into shape_shift

    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8cf665a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Fix getPixelShift for reversed axes, add reversed axis to mock

    @my-tien
    my-tien committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    78a7e5e View commit details
    Browse the repository at this point in the history

  2. Update baseline image of zzz_shape_shift_vertical 

    - removed selection
- reversed axis
    @my-tien
    my-tien committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    18e7c84 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Account for shift when dragging a shape

    @my-tien
    my-tien committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5509ee6 View commit details
    Browse the repository at this point in the history

  2. Support shape shift in texttemplate as well 

    - Add texttemplate with slope and xcenter to mock
    @my-tien
    my-tien committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6f8e5a6 View commit details
    Browse the repository at this point in the history

  3. Update baseline image after updated mock for texttemplate shape

    @my-tien
    my-tien committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7de45c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Refine description for x0shift/x1shift/y0shift/y1shift

    @my-tien
    my-tien committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9ac970a View commit details
    Browse the repository at this point in the history