Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getFullTransformMatrix in shadow DOM #6996

Merged
merged 3 commits into from
May 14, 2024

Conversation

OpportunityLiu
Copy link
Contributor

This PR add ShadowRoot detection in getElementAndAncestors, get a full list of dom ancestors, cross shadow dom.

Fix #5760

@archmoj archmoj added bug something broken community community contribution status: reviewable labels May 14, 2024
@archmoj
Copy link
Contributor

archmoj commented May 14, 2024

Thanks very much for the PR.
💃

@archmoj archmoj merged commit 8b09892 into plotly:master May 14, 2024
1 check passed
@OpportunityLiu OpportunityLiu deleted the fix/5760 branch May 15, 2024 02:51
@archmoj
Copy link
Contributor

archmoj commented May 29, 2024

Plotly.js v2.33.0 is out: https://github.com/plotly/plotly.js/releases/tag/v2.33.0
Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken community community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ploty.js in Shadow DOM did not handle CSS transform correctly
2 participants