-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent axis title standoff when title is one text line vs. multiple lines #6970
Conversation
…multiple lines. Previously, the standoff was calculated in the same way for all axis sides, but since the renderer draws from top left to bottom right, the code must be different for top/left axes titles and bottom/right axes titles: For top/left axes all lines after the first of a multiline title require extra space before the ticklabels, whereas for bottom/right axes, the drawing baseline needs to be shifted 1 line after the ticklabels to prevent overlap.
… y, g etc.) of the first line of the title as well.
Claimed to have standoff 8 although it has standoff 0.
Brilliant fix. 🎖️ 🏅 🥇 |
(cherry picked from commit 1e69c85)
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
Fixes: #6971.
![newplot(1)](https://private-user-images.githubusercontent.com/3898364/322866431-12ba016f-e031-4cd7-adfc-2b48db67fb76.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU0MjIyNjEsIm5iZiI6MTcyNTQyMTk2MSwicGF0aCI6Ii8zODk4MzY0LzMyMjg2NjQzMS0xMmJhMDE2Zi1lMDMxLTRjZDctYWRmYy0yYjQ4ZGI2N2ZiNzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDRUMDM1MjQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTY3MGJjNjVmNWIxMTcxMzZkZGRlYzU1MzE4YTI4YjY0Njk1ZTU0M2NjMDgyMTU2NTdiNTEzMjY2NDJmNDMyMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.WxFjzGjYkjY3pialRGjaV63DuhjRhsFEAK2yoVZ6Inw)
The bug (codepen):
Notice the different spacing between ticklabels and axis title!
Previously, the standoff was calculated in the same way for all axis sides, but since the renderer draws from top left to bottom right, the code must be different for top/left axes titles and bottom/right axes titles: For top/left axes all lines after the first of a multiline title require extra space before the ticklabels, whereas for bottom/right axes, the drawing baseline needs to be shifted 1 line after the ticklabels to prevent overlap. This is what this PR does.
FYI if you want to try out the code yourself: Debugging this is difficult because there are multiple drawing passes. One way to simplify this is to comment out
scootTitle
inTitles.draw
(src/components/titles.index.js:120
) whose only purpose is to shift the axis title in case it overlaps with either the paper border or another rendering object:Disclaimer
I am required to add that…the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.