Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shapes.layer "between" for drawing between gridlines and traces #6927

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Add shapes.layer "between" for drawing between gridlines and traces #6927

merged 13 commits into from
Mar 28, 2024

Commits on Mar 21, 2024

  1. Add shapes.layer value "belowtraces" for drawing shapes in between gr… 

    …idlines and traces
    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9bcf7e6 View commit details
    Browse the repository at this point in the history

  2. Add draftlog

    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0f9da5a View commit details
    Browse the repository at this point in the history

  3. Add baseline image for shapes_layer_below_traces.json

    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    267867b View commit details
    Browse the repository at this point in the history

  4. Make sure new test images run last

    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b25862d View commit details
    Browse the repository at this point in the history

  5. Update splom_test's innerSubplotNodeCnt and index of xaxislayer-above

    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7a7e57f View commit details
    Browse the repository at this point in the history

  6. Rename "belowtraces" to "between"

    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2b398d3 View commit details
    Browse the repository at this point in the history

  7. Add "between to newshape.layer as well. 

    Make line length of description shorter.
    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    70ebe72 View commit details
    Browse the repository at this point in the history

  8. Fix descriptions for shapes.layer and newshape.layer

    @my-tien
    my-tien committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    11e05a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Test more cases in shapes_layer_below_traces mock 

    - added axis y2 to test interaction between axes
- added shape label
- moved dashdot line to see more of its interaction with the gridlines
- removed transparency for easier visual checking
    @my-tien
    my-tien committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ff7ca7a View commit details
    Browse the repository at this point in the history

  2. Updated baseline image for changed shapes_layer_below_traces mock

    @my-tien
    my-tien committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    410f7cf View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. shapes_layer_below_traces mock: Make y and y2 gridlines visually dist… 

    …inct
    @my-tien
    my-tien committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    65a49a2 View commit details
    Browse the repository at this point in the history

  2. updated baseline image after changing shapes_layer_below_traces mock

    @my-tien
    my-tien committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4b86efd View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Update draftlogs/6927_add.md

    @archmoj
    archmoj committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fb7f228 View commit details
    Browse the repository at this point in the history