legend indentation #6874
Merged
legend indentation #6874
+99
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elative to the title
alexcjohnson
reviewed
Feb 1, 2024
src/components/legend/attributes.js
Outdated
| @@ -105,6 +105,13 @@ module.exports = { | |||
| editType: 'legend', | |||
| description: 'Determines what entrywidth means.', | |||
| }, | |||
| indentation: { | |||
| valType: 'number', | |||
| min: 0, | |||
There was a problem hiding this comment.
I could see us allowing negative indentation, to remove or reduce the padding to the left of many of the symbols. Many if not most legend symbols don't use the full itemwidth. The risk here is allowing symbols to bleed off the edge of the legend if you go too far, but I think that's acceptable if you have explicitly set a negative indentation. Maybe min: -15, ie half the minimum itemwidth?
There was a problem hiding this comment.
Yes the bleeding off the left edge was my concern as well. I have adapted the test image to showcase how it looks to indent with -15 for a line and a bar legend entry.
There was a problem hiding this comment.
Oh cool, we clip at the edge of the legend, that's perfect.
archmoj
added
feature
alexcjohnson
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
legend indentation
This PR adds the property
indentationtolayout.legendso that legend entries can be indented relative to the title.I have set the min value of this to 0 for now to avoid having to deal with adjusting the legend width and title positioning when the legend extends towards the left.