Fix hovering over Sankey node only fully highlights first trace #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
added
bug
archmoj
reviewed
Dec 5, 2023
archmoj
reviewed
Dec 5, 2023
|
Incorporated your suggestions @archmoj! :) |
|
Please add a test case in npm run test-jasmine sankeyTo run just the |
archmoj
reviewed
Dec 15, 2023
|
Hmm interesting, the tests pass on my end... But only when the browser is in full-screen. I hover over the right-most node, maybe that is not visible or something? |
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
|
Should work now! :) |
|
Great PR. 🏆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6328.
The issue was that only the label of the first link was considered when recursively highlighting traces.