-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hovering over Sankey node only fully highlights first trace #6799
Fix hovering over Sankey node only fully highlights first trace #6799
Conversation
Incorporated your suggestions @archmoj! :) |
Please add a test case in npm run test-jasmine sankey To run just the |
Hmm interesting, the tests pass on my end... But only when the browser is in full-screen. I hover over the right-most node, maybe that is not visible or something? |
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Should work now! :) |
Great PR. 🏆 |
Fixes #6328.
The issue was that only the label of the first link was considered when recursively highlighting traces.