Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download image and add image test for images with source and fast zsmooth #5386

Merged
merged 4 commits into from
Jan 12, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 7, 2021

Follow up of 5354.
Addressing #5354 (comment).

@plotly/plotly_js
cc: @almarklein

@archmoj archmoj added bug something broken status: reviewable labels Jan 7, 2021
@archmoj archmoj added this to the Next major milestone Jan 7, 2021
src/traces/image/plot.js Outdated Show resolved Hide resolved
@antoinerg
Copy link
Contributor

Thanks @archmoj for the PR! It looks good to me. 💃 as soon as the tests pass!

@archmoj archmoj merged commit 1529f3b into master Jan 12, 2021
@archmoj archmoj deleted the followup-5354 branch January 12, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants