Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include transforms in partial bundles #5379

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Include transforms in partial bundles #5379

merged 2 commits into from
Jan 7, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 6, 2021

Fixes #5378 | Before vs After.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jan 6, 2021
@archmoj archmoj added this to the v1.59.0 milestone Jan 6, 2021
@alexcjohnson
Copy link
Collaborator

Can you regenerate dist/README.md and post the diff here? Just curious how much size this adds to each bundle, as minified and gzipped.

@archmoj
Copy link
Contributor Author

archmoj commented Jan 6, 2021

This PR somehow fixes #5382 as well!

@archmoj
Copy link
Contributor Author

archmoj commented Jan 6, 2021

Can you regenerate dist/README.md and post the diff here? Just curious how much size this adds to each bundle, as minified and gzipped.

diff-1
diff-2

alexcjohnson
alexcjohnson approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 That seems like a small enough cost that it's worthwhile in all the bundles.

@archmoj archmoj merged commit 6656ca3 into master Jan 7, 2021
@archmoj archmoj deleted the add-transforms-to-partial-bundles branch January 7, 2021 01:59
@archmoj archmoj mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Missing transforms on partial bundles
2 participants
@archmoj @alexcjohnson