Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade color* modules to working versions to fix import #5223

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 20, 2020

Recent new color* module bumps made it difficult for webpack users as well as chart-studio to import/require plotly.js.
While this could possibly be addressed by retargeting "main" in package.json see #5221,
such a change require a minor release.
In order to address this issue in patch release and successfully upgrade chart-studio from v1.55.2 to v1.57.1 for now,
this PR downgrade color* to versions before PR #5172.

@plotly/plotly_js
cc: @dmt0

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 2504f1e into master Oct 20, 2020
@archmoj archmoj deleted the revert-bump-color-modules branch October 20, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants