translation to korean #4315

JJByun · 2019-10-29T14:02:26Z

translation-ko

Thanks for your interest in plotly.js!

Translations:

Make a PR directly to the main repository
Please @ mention a few other speakers of this language who can help review your translations.
If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
You should only update files in lib/locales/, not those in dist/

Features, Bug fixes, and others:

Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.

Before opening a pull request, developer should:

git rebase their local branch off the latest master,
make sure to not git add the dist/ folder (the dist/ is updated only on version bumps),
make sure to commit changes to the package-lock.json file (if any),
write an overview of what the PR attempts to do,
select the Allow edits from maintainers option (see this article for more details).

Note that it is forbidden to force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please git merge master into your PR branch instead of git rebase master.

traslation-ko

etpinard · 2019-10-29T14:08:31Z

Ha that's interesting.

That's the first time someone sends us translations of the .md files in this repo.

I'm not sure we want to have all the translation copies of our .md files checked into the repo. I've seen a lot of projects use Github Wikis for that, maybe we should go down this path.

Pinging @nicolaskruchten @chriddyp @alexcjohnson about this.

JJByun · 2019-10-29T14:47:58Z

@etpinard I thought translation is including document files(such as README.md...).
It's impossible to merge documentation .md files?

translate ko.js file

nicolaskruchten · 2019-10-29T17:34:12Z

Wow, this is great, thanks so much for all this work! I have no problem merging this in in principle but I do worry about how to ensure the translated versions of the ReadMe etc stay in sync as we make changes to the english versions...

etpinard · 2019-10-29T18:19:30Z

@JJByun can you make a separate PR that only includes the patch you made to lib/locales/ko.js?

We'll be able to merge that without reaching a consensus on how and where to translate our .md files. Thanks!

JJByun · 2019-10-30T02:19:46Z

@etpinard sure I will send PR lib/locales/ko.js without .md files.

etpinard · 2019-10-30T16:25:12Z

Thanks @JJByun !!

Now, could you please @ mention a few other speakers of this language who can help review your translations?

JJByun · 2019-10-31T03:40:14Z

@etpinard thanks your comment. I tried to @ mention my co-worker but it didn’t work.(recommendation didn’t show) Do you know how to mention? they are in my organization team.

archmoj · 2019-10-31T06:22:31Z

@etpinard thanks your comment. I tried to @ mention my co-worker but it didn’t work.(recommendation didn’t show) Do you know how to mention? they are in my organization team.

You may share the link them and ask them to review the PR.

lch7167 · 2019-11-02T03:11:38Z

hello

dmakth · 2019-11-02T03:17:47Z

comment

Geipro · 2019-11-02T03:41:33Z

Thanks!

JJByun · 2019-11-02T03:44:24Z

@archmoj Thanks for your advise.
@lch7167 @dmakth @Proscream We translated together.

archmoj · 2019-11-03T19:03:21Z

@JJByun @lch7167 @dmakth @Proscream Thanks very much for the contribution.
For reviewers, here we need to mention GitHub users who were not the authors of the same PR.

JJByun · 2019-11-05T03:14:30Z

@archmoj you mean I do @ mention other user who can review the translation?

archmoj · 2019-11-05T03:18:18Z

@archmoj you mean I do @ mention other user who can review the translation?

@JJByun Yes please.

ChoiHeon · 2019-11-06T07:35:57Z

26line : 추적 -> 트레이스
29line: 그래프 -> 차트
31line: IE는 svg만을 지원합니다. 포맷을 svg로 변경하세요
32line: Lasso -> 올가미 선택
46line: Toggle -> 스위치
47line: 스위치로 hover과 가장 가까운 데이터를 보여줍니다

modify some words

JJByun · 2019-11-06T07:49:15Z

@archmoj Thanks to @ChoiHeon , I accepted some wrong words.

archmoj · 2019-11-13T16:39:58Z

@JJByun Thanks for the revision.
Now would you mind fixing the syntax (missing a quotation) on the line below?

plotly.js/lib/locales/ko.js

Line 36 in f390656

'Reset': 리셋',

JJByun · 2019-11-14T01:14:24Z

@archmoj sure! no problem.

reset : 리셋 -> 초기화

archmoj · 2019-11-14T16:15:26Z

lib/locales/ko.js

-        'Reset camera to last save': 'camera를 마지막으로 저장한 값으로 리셋',
-        'Reset view': 'view 리셋',
-        'Reset views': 'views 리셋',
+        'Reset': 초기화',


I think this line should be

'Reset': '초기화',

Now missing a start quotation mark after the key.
@JJByun would you please fix that so that tests pass on the CircleCI?
Thanks!

JJByun · 2019-11-15T01:28:45Z

@archmoj I understand what you want. I fix the quotation and send PR Thanks!

delete space

archmoj · 2019-11-15T22:06:35Z

@JJByun thanks for the fixes.
@ChoiHeon would you mind having another look at this PR and/or mention others who can help with the second review?

Geipro · 2019-11-16T10:36:04Z

I will ask a man who is doing other open-source translation.

update some words 25 line: 'hover 위의 데이터와 비교합니다'->'마우스를 올리면 데이터와 비교합니다' 42 line: 'hover에 근접한 데이터 보이기' -> '마우스를 올리면 근접한 데이터를 보이기' 47 line: '스위치로 hover와 가장 가까운 데이터를 보여줍니다' -> '스위치로 마우스를 올렸을 때 가장 가까운 데이터를 보여줍니다'

jhin102 · 2019-11-17T10:26:38Z

25: 'hover 위의 데이터와 비교합니다' ->'마우스를 올리면 데이터와 비교합니다'
42: 'hover에 근접한 데이터 보이기' -> '마우스를 올리면 근접한 데이터를 보이기'
47: '스위치로 hover와 가장 가까운 데이터를 보여줍니다' -> '스위치로 마우스를 올렸을 때 가장 가까운 데이터를 보여줍니다'

JJByun · 2019-11-17T10:49:52Z

@Nogan95 reviewed my PR and I accept it. @archmoj would you check my file again please?

CreatiCoding · 2019-11-18T10:26:15Z

Hello, Plotly!

CreatiCoding · 2019-11-18T11:08:46Z

lib/locales/ko.js

+    dictionary: {
+        'Autoscale': '자동 크기지정',
+        'Box Select': '박스 선택',
+        'Click to enter Colorscale title': '클릭하여 Colorscale 제목을 지정합니다',


Suggested change

'Click to enter Colorscale title': '클릭하여 Colorscale 제목을 지정합니다',

'Click to enter Colorscale title': 'Colorscale 제목을 지정하려면 클릭하시오',

Click 으로 명령 형태는 다 저런식으로 수정하는게 좋다는거죠?

무조건 그런건 아니고 자연스럽다면 그렇게 바꾸는게 좋은 것 같아요

CreatiCoding

전체적으로 문장이 명령문이기 때문에 번역을 명령문 형태로 하는게 더 좋을 것 같아요!

Overall, statements are imperative sentence type, so it's better to translate it into a imperative sentence type!

CreatiCoding · 2019-11-18T11:09:19Z

lib/locales/ko.js

+        'Autoscale': '자동 크기지정',
+        'Box Select': '박스 선택',
+        'Click to enter Colorscale title': '클릭하여 Colorscale 제목을 지정합니다',
+        'Click to enter Component A title': '클릭하여 A데이터의 제목을 지정합니다',


Suggested change

'Click to enter Component A title': '클릭하여 A데이터의 제목을 지정합니다',

'Click to enter Component A title': 'A 데이터의 제목을 지정하려면 클릭하시오',

CreatiCoding · 2019-11-18T11:09:42Z

lib/locales/ko.js

+        'Box Select': '박스 선택',
+        'Click to enter Colorscale title': '클릭하여 Colorscale 제목을 지정합니다',
+        'Click to enter Component A title': '클릭하여 A데이터의 제목을 지정합니다',
+        'Click to enter Component B title': '클릭하여 B데이터의 제목을 지정합니다',


Suggested change

'Click to enter Component B title': '클릭하여 B데이터의 제목을 지정합니다',

'Click to enter Component B title': 'B 데이터의 제목을 지정하려면 클릭하시오',

CreatiCoding · 2019-11-18T11:10:39Z

lib/locales/ko.js

+        'Click to enter Colorscale title': '클릭하여 Colorscale 제목을 지정합니다',
+        'Click to enter Component A title': '클릭하여 A데이터의 제목을 지정합니다',
+        'Click to enter Component B title': '클릭하여 B데이터의 제목을 지정합니다',
+        'Click to enter Component C title': '클릭하여 C데이터의 제목을 지정합니다',


CreatiCoding · 2019-11-18T11:14:49Z

lib/locales/ko.js

+        'Show closest data on hover': '마우스를 올리면 근접한 데이터를 보이기',
+        'Snapshot succeeded': 'Snapshot 성공',
+        'Sorry, there was a problem downloading your snapshot!': '죄송합니다, snapshot을 다운로드 중 문제가 발생했습니다!',
+        'Taking snapshot - this may take a few seconds': 'snapshot을 찍습니다 - 이것은 몇 초가 소요될 수 있습니다',


동명사형태인 것 같아요

Suggested change

'Taking snapshot - this may take a few seconds': 'snapshot을 찍습니다 - 이것은 몇 초가 소요될 수 있습니다',

'Taking snapshot - this may take a few seconds': '스냅샷 찍기 - 수 초가 걸릴 수 있습니다.'

JJByun · 2019-11-18T11:31:12Z

@CreatiCoding 감사해요 형!! 고쳐서 PR 날릴게요

fix some words

CreatiCoding · 2019-11-19T00:03:22Z

LGTM

JJByun · 2019-11-19T01:35:48Z

@archmoj All reviews are done :)

JJByun · 2019-11-26T03:17:19Z

@archmoj Hi! Is still something problem?

etpinard · 2019-11-26T14:35:47Z

Hi @JJByun - your PR is complete.

We'll merge and release it as part of v1.52.0 set to be released in the first week of January 2020.

JJByun · 2019-11-28T05:11:01Z

@etpinard I got it. Thank you :)

etpinard · 2019-12-03T19:04:12Z

Merging. Set to be released in v1.52.0

translation to korean

6ae779f

traslation-ko

JJByun changed the title ~~translation to korean~~ translation to korean type: translation Oct 29, 2019

JJByun changed the title ~~translation to korean type: translation~~ translation to korean Oct 29, 2019

translation to korean

9e9da79

translate ko.js file

translation-ko without .md files

d4972c8

etpinard added the type: translation label Oct 30, 2019

update ko.js

f390656

modify some words

update ko.js

f19767d

reset : 리셋 -> 초기화

archmoj reviewed Nov 14, 2019

View reviewed changes

Update ko.js

229c2a9

update ko.js

9b2db6d

delete space

archmoj added this to the v1.52.0 milestone Nov 15, 2019

CreatiCoding reviewed Nov 18, 2019

View reviewed changes

CreatiCoding suggested changes Nov 18, 2019

View reviewed changes

CreatiCoding reviewed Nov 18, 2019

View reviewed changes

update ko.js

1a03f86

fix some words

etpinard merged commit fb8b28a into plotly:master Dec 3, 2019

jdamiba mentioned this pull request Jan 9, 2020

1.52 Dash QA #4476

Closed

snyk-bot mentioned this pull request Feb 4, 2020

[Snyk] Upgrade plotly.js from 1.45.3 to 1.52.0 beauremus/ftp-viewer#1

Merged

snyk-bot mentioned this pull request Feb 22, 2020

[Snyk] Upgrade plotly.js from 1.35.2 to 1.52.1 raindigi/eShopOnContainersAI#1

Open

snyk-bot mentioned this pull request Mar 18, 2020

[Snyk] Upgrade plotly.js from 1.52.0 to 1.52.2 beauremus/ftp-viewer#19

Open

snyk-bot mentioned this pull request Apr 17, 2020

[Snyk] Upgrade plotly.js from 1.41.3 to 1.52.3 dunzoit/redash#4

Open

	'Click to enter Colorscale title': '클릭하여 Colorscale 제목을 지정합니다',
	'Click to enter Colorscale title': 'Colorscale 제목을 지정하려면 클릭하시오',

	'Click to enter Component A title': '클릭하여 A데이터의 제목을 지정합니다',
	'Click to enter Component A title': 'A 데이터의 제목을 지정하려면 클릭하시오',

	'Click to enter Component B title': '클릭하여 B데이터의 제목을 지정합니다',
	'Click to enter Component B title': 'B 데이터의 제목을 지정하려면 클릭하시오',

	'Taking snapshot - this may take a few seconds': 'snapshot을 찍습니다 - 이것은 몇 초가 소요될 수 있습니다',
	'Taking snapshot - this may take a few seconds': '스냅샷 찍기 - 수 초가 걸릴 수 있습니다.'

translation to korean #4315

translation to korean #4315

Conversation

JJByun commented Oct 29, 2019

Translations:

Features, Bug fixes, and others:

etpinard commented Oct 29, 2019

JJByun commented Oct 29, 2019

nicolaskruchten commented Oct 29, 2019

etpinard commented Oct 29, 2019

JJByun commented Oct 30, 2019

etpinard commented Oct 30, 2019

JJByun commented Oct 31, 2019

archmoj commented Oct 31, 2019

lch7167 commented Nov 2, 2019

dmakth commented Nov 2, 2019

Geipro commented Nov 2, 2019

JJByun commented Nov 2, 2019

archmoj commented Nov 3, 2019

JJByun commented Nov 5, 2019

archmoj commented Nov 5, 2019

ChoiHeon commented Nov 6, 2019

JJByun commented Nov 6, 2019

archmoj commented Nov 13, 2019

JJByun commented Nov 14, 2019

Choose a reason for hiding this comment

JJByun commented Nov 15, 2019

archmoj commented Nov 15, 2019

Geipro commented Nov 16, 2019

jhin102 commented Nov 17, 2019

JJByun commented Nov 17, 2019 • edited Loading

CreatiCoding commented Nov 18, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CreatiCoding left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JJByun commented Nov 18, 2019

CreatiCoding commented Nov 19, 2019

JJByun commented Nov 19, 2019 • edited Loading

JJByun commented Nov 26, 2019

etpinard commented Nov 26, 2019

JJByun commented Nov 28, 2019

etpinard commented Dec 3, 2019

JJByun commented Nov 17, 2019 •

edited

Loading

CreatiCoding commented Nov 18, 2019 •

edited

Loading

CreatiCoding left a comment •

edited

Loading

JJByun commented Nov 19, 2019 •

edited

Loading