Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "layout first" transition race condition #4262

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Oct 8, 2019

- make testing `invocationOrder` possible, along side
  "did get called" vs "did not get called" checks
- adapt assertSpies calls that checked arguments from multiple calls
  of a given spy, now each "expectations" item corresponds to
  one function call
... to remove "jump" caused by transitionTraces()
@etpinard etpinard added bug something broken status: reviewable labels Oct 8, 2019
@archmoj
Copy link
Contributor

archmoj commented Oct 9, 2019

Excellent.
💃

@etpinard
Copy link
Contributor Author

etpinard commented Oct 9, 2019

Thanks for the review @archmoj - note that the changes here might add some "flakiness" to the transition_test.js suite. If you notice a particular test in that suite failing intermittently in the coming days, please let me know.

@etpinard etpinard merged commit abbd92d into master Oct 9, 2019
@etpinard etpinard deleted the fix-layout-first-transition-race-condition branch October 9, 2019 13:21
@archmoj
Copy link
Contributor

archmoj commented Oct 9, 2019

Thanks for the review @archmoj - note that the changes here might add some "flakiness" to the transition_test.js suite. If you notice a particular test in that suite failing intermittently in the coming days, please let me know.

Yes. I noticed one test failed the first time. But then it passed the second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar transition oddities
2 participants