Reorganise gl tests for less flakiness #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new gl3d_hover_click_test.js - mv a few scatter3d-only test to scatter3d_test.js
... which tests the old scattergl fancy / fast logic
in the pre-regl scattergl sub-modules
... in scattergl_test.js and scattergl_select_test.js
|
💃 💃 |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my follow-up on #3853 (comment) which appears to make our flaky
@gltests less flaky (3/3 successful runs so far).In brief,
gl3d_plot_interact_test.jsare moved to new suitegl3d_hover_click_test.jsscatterglinteractions tests are divided up evenly (and logically) ingl2d_plot_interact_test.js,scattergl_test.jsandscattergl_select_test.jscc @plotly/plotly_js It's the not the end of the story, but this PR should be a solid step forward toward non-flaky
@gltests.