Disable dark highlights from Mesh3d #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
added
bug
|
Nice fix. Is there any way to test this fix? |
|
I used a mobile with this codepen. |
|
Ok, sounds good 💃 |
|
Thanks for the quick fix @archmoj ! This thing will be out today, but I'll wait a couple more hours before releasing 1.44.1 in case other regression are detected. |
|
It would be great if we could follow up with #3380. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3462 using newly published
gl-mesh3dmodule by not allowing negative highlights.Example below illustrate a desirable result after using
gl-mesh3dv.2.0.6@etpinard cc: @plotly/plotly_js