Skip to content

Commit

Permalink
update jshintrc:
Browse files Browse the repository at this point in the history
- rm maxparms
- rm maxstatements
- bump maxdepth to 6
- add jasmine env
  • Loading branch information
etpinard committed Nov 16, 2015
1 parent 2de1313 commit 6c279ee
Showing 1 changed file with 4 additions and 18 deletions.
22 changes: 4 additions & 18 deletions .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
// environments
"browser": true, // Define globals exposed by modern browsers.
"jquery": false, // Define globals exposed by jQuery.

This comment has been minimized.

Copy link
@etpinard

etpinard Nov 16, 2015

Author Contributor

@alexcjohnson done here

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Nov 16, 2015

Collaborator

Oh right, I was thinking of the /* global: <...>:false */ syntax but that's not what this is at all - cool, so we've already marked jQuery as a pariah 😄

"node": true, // Define globals exposed by Node.js.
"node": true, // Define globals exposed by Node.js.
"jasmine": true, // Define globals exposed by jasmine

// enforcing (true means bug us about it)
"camelcase": false, // Force all variable names to use either camelCase style or UPPER_CASE with underscores.
Expand All @@ -15,10 +16,8 @@
"indent": 4, // Enforce tab width of 4 spaces.
"latedef": "nofunc", // Prohibit use of a variable before it is defined.
"maxcomplexity": false, // This option lets you control cyclomatic complexity throughout your code.
"maxdepth": 5, // This option lets you control how nested do you want your blocks to be
"maxdepth": 6, // This option lets you control how nested do you want your blocks to be
"maxlen": 120, // Enforce line length to 120 characters
"maxparams": 5, // This option lets you set the max number of formal parameters allowed per function
"maxstatements": 60, // This option lets you set the max number of statements allowed per function
"newcap": true, // Require capitalized names for constructor functions.
"noarg": true, // This option prohibits the use of arguments.caller and arguments.callee.
"noempty": true, // This option warns when you have an empty block in your code.
Expand All @@ -31,7 +30,6 @@
"undef": true, // Prohibit use of explicitly undeclared variables.
"unused": true, // Warn when variables are defined but never used.


// relaxing (true means DON'T bug us about it)
"asi": false, // This option suppresses warnings about missing semicolons.
"boss": false, // This option suppresses warnings about the use of assignments in cases where comparisons are expected.
Expand Down Expand Up @@ -61,15 +59,6 @@

// global pre defined variables
"predef": [
"angular",
"afterEach",
"beforeEach",
"describe",
"encodeURIComponent",
"expect",
"inject",
"it",
"spyOn",
"JSON",
"Uint8Array",
"Uint16Array",
Expand All @@ -78,9 +67,6 @@
"Int16Array",
"Int32Array",
"Float32Array",
"Float64Array",
"require",
"module",
"document"
"Float64Array"
]
}

2 comments on commit 6c279ee

@etpinard
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 also axe jquery and just bring it back in tests where needed?

Please sign in to comment.