Merge pull request #7044 from plotly/test_for_5879

Adjust failing modebar test after merging PR #5879
plotly · Jul 17, 2024 · 5fde4d9 · 5fde4d9
2 parents e2653aa + cadbbf6
commit 5fde4d9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/components/modebar/manage.js b/src/components/modebar/manage.js
@@ -246,7 +246,6 @@ function getButtonGroups(gd) {
                     enableHover('hoverClosestGl2d');
                     enableHover('hoverClosestPie');
                 } else if(b === 'v1hovermode') {
-                    enableHover('toggleHover');
                     enableHover('hoverClosestCartesian');
                     enableHover('hoverCompareCartesian');
                     enableHover('hoverClosestGeo');

diff --git a/test/jasmine/tests/modebar_test.js b/test/jasmine/tests/modebar_test.js
@@ -1642,7 +1642,7 @@ describe('ModeBar', function() {
                 ]);
             })
             .then(function() {
-                expect(countButtons()).toBe(initial + 4, 'skip duplicates');
+                expect(countButtons()).toBe(initial + 5, 'skip duplicates');
 
                 return Plotly.relayout(gd, 'modebar.add', [
                     'drawline',
@@ -1656,6 +1656,13 @@ describe('ModeBar', function() {
             })
             .then(function() {
                 expect(countButtons()).toBe(initial);
+
+                return Plotly.relayout(gd, 'modebar.add', [
+                    'togglehover'
+                ]);
+            })
+            .then(function() {
+                expect(countButtons()).toBe(initial + 1, 'add togglehover');
             })
             .then(done, done.fail);
         });