Merge pull request #5383 from plotly/test-avoid-function-constructors…

…-in-partial-bundles Add publish test for avoiding function constructors in non-gl(2d|3d) partial bundles
plotly · Jan 7, 2021 · 177842f · 177842f
2 parents 6656ca3 + 3249034
commit 177842f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -166,6 +166,9 @@ jobs:
             echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plotly.js
             echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plotly.min.js
             echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plot-schema.json
+      - run:
+          name: Test bundles
+          command: npm run no-new-func
 
 workflows:
   version: 2

diff --git a/package.json b/package.json
@@ -31,6 +31,7 @@
     "watch": "node tasks/watch.js",
     "lint": "eslint --version && eslint .",
     "lint-fix": "eslint . --fix || true",
+    "no-new-func": "eslint --no-ignore --no-eslintrc --rule '{no-new-func: error}' $(find dist -type f -iname '*.js' | grep -v plotly-gl* | grep -v plotly-with-meta.* | grep -v plotly.js | grep -v plotly.min.js | grep -v MathJax.js)",
     "docker": "node tasks/docker.js",
     "pretest": "node tasks/pretest.js",
     "test-jasmine": "karma start test/jasmine/karma.conf.js",