Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rehighlights dcc.Markdown when it is updated #2909

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

leeagustin
Copy link
Contributor

Fixes #2895.

The problem is that highlight.js was changed in highlightjs/highlight.js@3987abe, which prevents re-highlighting an element.

The attribute data-highlighted="yes" flags an element as highlighted. Hence, the solution is to remove this attribute before the code is re-highlighted.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Re-highlights dcc.Markdown after it is updated
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@gvwilson gvwilson added feature something new P2 needed for current cycle labels Aug 13, 2024
@gvwilson
Copy link
Contributor

@T4rk1n can you please have a look and let us know if we can merge?

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, thank you.

@T4rk1n T4rk1n merged commit 0d9b9da into plotly:dev Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P2 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown does not update code component properly after callback update.
4 participants