fix some typing issues #2841
Merged
fix some typing issues #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielIskandar
requested review from
alexcjohnson,
T4rk1n and
ndrezn
as code owners
T4rk1n
requested changes
Apr 29, 2024
explainerdashboard
Outdated
package.json
Outdated
| @@ -49,7 +49,7 @@ | |||
| "devDependencies": { | |||
| "@lerna/filter-options": "^6.4.1", | |||
| "husky": "8.0.3", | |||
| "lerna": "^6.6.2" | |||
| "lerna": "^6.4.1" | |||
There was a problem hiding this comment.
Need to rollback to 6.6.2 > 6.4.1
dash/custom_types.py
Outdated
There was a problem hiding this comment.
Since this is a public module, we cannot rename without it being a breaking change.
T4rk1n
reviewed
May 28, 2024
Comment on lines
+408
to
+413
| long_callback_manager: Optional[ | ||
| Any | ||
| ] = None, # Type should be specified if possible | ||
| background_callback_manager: Optional[ | ||
| Any | ||
| ] = None, # Type should be specified if possible |
There was a problem hiding this comment.
Both of those should be of type dash.long_callback.managers.BaseLongCallbackManager
Comment on lines
+397
to
+400
| meta_tags: Optional[List[Dict[str, Any]]] = None, | ||
| index_string: str = _default_index, | ||
| external_scripts: Optional[List[Union[str, Dict[str, Any]]]] = None, | ||
| external_stylesheets: Optional[List[Union[str, Dict[str, Any]]]] = None, |
There was a problem hiding this comment.
Those Any in the Dict would be str
| @@ -375,40 +378,43 @@ class Dash: | |||
| STARTUP_ROUTES: list = [] | |||
|
|
|||
There was a problem hiding this comment.
we can add server: flask.Flask here.
Closed
gvwilson
added
P2
|
@DanielIskandar are you interested in updating this one so that we can merge it? thanks - @gvwilson |
T4rk1n
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!
Contributor Checklist
optionals
CHANGELOG.md