Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build artifacts and update build process #1734

Merged
merged 17 commits into from
Sep 1, 2021
Merged

Conversation

HammadTheOne
Copy link
Contributor

@HammadTheOne HammadTheOne commented Aug 30, 2021

This PR removes build artifacts from the dev branch of dash and updates the build scripts. It also includes some cleanup for obsolete html components.

Contributor Checklist

  • TODO

    • Update package.json scripts to a single npm build script to build renderer and components.
    • Update CONTRIBUTING.md
    • Update dash-core release process (https://github.com/plotly/dash-core/pull/336)
    • Remove obsolete html components.
    • Fix table helpers import issue (if in scope)
  • I have run the tests locally and they passed. (refer to testing section in contributing)

optionals

  • I have added entry in the CHANGELOG.md

@alexcjohnson alexcjohnson mentioned this pull request Aug 30, 2021
3 tasks
@HammadTheOne HammadTheOne marked this pull request as ready for review August 30, 2021 23:17
Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @alexcjohnson give the final OK, but this looks good from my end.

Thanks @HammadTheOne!

CHANGELOG.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Love it! All sorts of good stuff here.

@HammadTheOne HammadTheOne merged commit e25f5c6 into dev Sep 1, 2021
@HammadTheOne HammadTheOne deleted the remove-artifacts branch September 1, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants