Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Re-add new tooltip component #982

Closed
wants to merge 16 commits into from
Closed

Re-add new tooltip component #982

wants to merge 16 commits into from

Conversation

xhluca
Copy link

@xhluca xhluca commented Jul 26, 2021

This is an updated attempt for: #940

Note #941 was also added to this PR in 6a18fd9

Related:

TODOs for demo:

  • Image example that uses URLs
  • Image example that reads images from file system and base64 encodes them
  • Clientside callback example with URLs
  • Example with loading state and a time.sleep(1) to simulate a long running callback
  • Serverside callback example with a nicely formatted tooltip made with HTML and inline CSS with a little box shadow, similar to the style of the nytimes:
  • Clientside callback example of ^

@alexcjohnson
Copy link
Collaborator

@xhlulu please drop package-lock.json from this PR, since you aren't updating package.json. If you do change package.json, note that dash core is now using node 16 / npm 7

Pass a bbox through graph hover data
@xhluca
Copy link
Author

xhluca commented Aug 2, 2021

@xhlulu please drop package-lock.json from this PR, since you aren't updating package.json. If you do change package.json, note that dash core is now using node 16 / npm 7

Sure. I removed the commit that added package-lock.json and did a force push

xhlulu added 10 commits August 2, 2021 19:09
This is outdated since absolute tooltip improves upon this
Remove some z-index positioning that were not relevant, change the props
It's not clear how those props will be used and could be confusing.
It's better to remove them for now and add them later if needed
AbsoluteTooltip.css has been superceded by style jsx
@xhluca
Copy link
Author

xhluca commented Aug 16, 2021

@alexcjohnson am I supposed to commit NAMESPACE changes as well?

@xhluca
Copy link
Author

xhluca commented Aug 16, 2021

@alexcjohnson I feel this PR is ready for review. A few questions for review:

  • any idea why the 27 tests are failing? are we still supporting 2.7?
  • What name should I give it? It's currently called dcc.AbsoluteTooltip but i'm certain there's a better name than this.

When loading, the component will display the loading_text, otherwise
it will show the props.children
@alexcjohnson
Copy link
Collaborator

Closing - will remake shortly in the monorepo

@alexcjohnson alexcjohnson deleted the tooltip-component-new branch August 30, 2021 19:52
alexcjohnson referenced this pull request in plotly/dash Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants