-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode/settings.json markdown added #6357
vscode/settings.json markdown added #6357
Conversation
@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
✅ Deploy Preview for plone-components canceled.
|
@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
@aadityaforwork please read and follow First-time contributors, Contributing to Plone, and Contributing to Volto. |
@davisagli I noticed that Plone packages with I was about to port this to plone.api and plone.restapi, and this gave me pause. |
@stevepiercy I don't see an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aadityaforwork Your PR still includes files that should not be here. I would expect changes only to vscodesettings.js, plus the file in packages/volto/news.
Hello @davisagli I have addressed the changes you asked if anything further is to be done please let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review comments. Otherwise LGTM.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
…ityaforwork/volto into 6354-Disabled-VSCode-feature
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no changes in pnpm-lock.yaml since there are no changes to dependencies in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line added and removed are the same although I discarded all the changes it is still showing an unnecessary file change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover there are no dependency changes also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aadityaforwork It's showing that you removed a newline character at the end of the file.
Should be ok, I'll merge once the current CI builds finish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I will keep in mind next time thank you!
Issue number 6354 resolved feedback required if any further changes are to be done.