Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode/settings.json markdown added #6357

Merged
merged 11 commits into from
Oct 2, 2024

Conversation

aadityaforwork
Copy link
Member

Issue number 6354 resolved feedback required if any further changes are to be done.

@mister-roboto
Copy link

@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 85831b8
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66fd79b5cd5fe80008de8ce6

@mister-roboto
Copy link

@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

package.json Outdated Show resolved Hide resolved
packages/volto/locales/ca/LC_MESSAGES/volto.po Outdated Show resolved Hide resolved
@mister-roboto
Copy link

@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@stevepiercy
Copy link
Collaborator

@aadityaforwork please read and follow First-time contributors, Contributing to Plone, and Contributing to Volto.

@stevepiercy
Copy link
Collaborator

@davisagli I noticed that Plone packages with plone/meta have this thingie called .editorconfig. Should this setting go in that file or .meta.toml?

I was about to port this to plone.api and plone.restapi, and this gave me pause.

@davisagli
Copy link
Sponsor Member

@stevepiercy I don't see an .editorconfig setting available for requesting that autoformatting be entirely disabled.

Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aadityaforwork Your PR still includes files that should not be here. I would expect changes only to vscodesettings.js, plus the file in packages/volto/news.

@aadityaforwork
Copy link
Member Author

@aadityaforwork Your PR still includes files that should not be here. I would expect changes only to vscodesettings.js, plus the file in packages/volto/news.

Hello @davisagli I have addressed the changes you asked if anything further is to be done please let me know!

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments. Otherwise LGTM.

packages/volto/news/6354.documentation Outdated Show resolved Hide resolved
packages/volto/news/6354.documentation Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no changes in pnpm-lock.yaml since there are no changes to dependencies in package.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line added and removed are the same although I discarded all the changes it is still showing an unnecessary file change!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreover there are no dependency changes also

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aadityaforwork It's showing that you removed a newline character at the end of the file.

Should be ok, I'll merge once the current CI builds finish.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I will keep in mind next time thank you!

@davisagli davisagli merged commit c3e5be1 into plone:main Oct 2, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants