Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getting the the variation when migrating collections to listing blocks #158

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

pbauer
Copy link
Sponsor Member

@pbauer pbauer commented Jul 26, 2024

No description provided.

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@pbauer
Copy link
Sponsor Member Author

pbauer commented Jul 26, 2024

@jenkins-plone-org please run jobs

@pbauer pbauer merged commit 5b37bd1 into main Jul 29, 2024
15 of 17 checks passed
@pbauer pbauer deleted the fix_listing_block_migration branch July 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants