Reindex AT content on PATCH #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
davisagli
reviewed
Jun 23, 2018
| @@ -67,6 +67,7 @@ def __call__(self, validate_all=False, data=None): | |||
| notify(ObjectInitializedEvent(obj)) | |||
| obj.at_post_create_script() | |||
| else: | |||
| obj.reindexObject() | |||
There was a problem hiding this comment.
Do we not also want this when the creation flag is set?
There was a problem hiding this comment.
When the creation flag is set, the object will be added to a container and reindexed because of that: https://github.com/zopefoundation/Products.CMFCore/blob/master/Products/CMFCore/CMFCatalogAware.py#L272
Thus I would like to avoid indexing twice, though collective.indexing would solve that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531