Propose a fix for the issue #253 by not comparing IDatetime fields wh… #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en patching and set the value always.
|
@tisto @buchi @lukasgraf It's the simplest and less intrusive solution that I could think of to solve this problem. Let me know what do you think. |
|
I haven't been involved with this part of the original implementation, so I'm afraid I can't really give any meaningful feedback without fully diving into it. |
|
This will only work around the error you currently get when trying to create an event through the REST API. However you get an event with start/end dates without tzinfo which is inconsistent to events created through the web. Most likely this will lead to errors when viewing/editing the event with Plone's default views/forms. See discussion in #253 |
…offset-aware Conflicts: CHANGES.rst
|
Closing in favor of: #394 |
tisto
deleted the
issue-253-cannot-compare-offset-naive-and-offset-aware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en patching and set the value always.