Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: exclude_from_nav True vs None #579

Closed
jensens opened this issue Jul 13, 2018 · 0 comments · Fixed by #580
Closed

testing: exclude_from_nav True vs None #579

jensens opened this issue Jul 13, 2018 · 0 comments · Fixed by #580
Labels
01 type: bug

Comments

@jensens
Copy link
Sponsor Member

jensens commented Jul 13, 2018

With plone.indexer not acquiring attributes anymore fixing plone/Products.CMFPlone#2469, the test at

plone.restapi/src/plone/restapi/tests/test_search.py

Line 175 in 1b88d93

u'exclude_from_nav': False,

breaks, b/c attribute exclude_from_nav is not set directly on the DXTestDocument and also not acquired, so it is None here instead of False.

Now, I simply could change this, but testing with older versions of plone.indexer it would fail again.

see also plone/Products.CMFPlone#2469
jensens added a commit that referenced this issue Jul 17, 2018
@jensens
fixes #579
d8a9b85
@jensens jensens mentioned this issue Jul 17, 2018
Merged
agitator added a commit that referenced this issue Jul 17, 2018
@agitator
Merge pull request #580 from plone/fix-579
d8b93dd 
fixes #579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #579 plone/plone.restapi
1 participant
@jensens