Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app tile settings and event handling cleanup [3.0.x] #542

Merged
merged 5 commits into from
May 10, 2023
Merged

Fix app tile settings and event handling cleanup [3.0.x] #542

merged 5 commits into from
May 10, 2023

Conversation

petschki
Copy link
Member

@petschki petschki commented May 10, 2023 •
edited
Loading

besides some code cleanup this fixes #541

This also fixes the "ESC" key issue where the tile wasn't cleanly dismissed.

@petschki petschki changed the title Fix app tile settings and event handling cleanup Fix app tile settings and event handling cleanup [3.0.x] May 10, 2023
@petschki petschki requested a review from frapell May 10, 2023 09:32
frapell
frapell approved these changes May 10, 2023
View reviewed changes
Copy link
Sponsor Member

@frapell frapell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly

@frapell frapell merged commit 93cadc7 into 3.0.x May 10, 2023
@frapell frapell deleted the petschki-fix-app-tile-settings-and-event-cleanup branch May 10, 2023 11:43
@frapell frapell mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frapell frapell frapell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petschki @frapell