Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: Correctly await the TinyMCE initialization and avoid Tiny… #535

Merged
merged 4 commits into from
Apr 22, 2023

Conversation

thet
Copy link
Member

@thet thet commented Apr 21, 2023

…MCE double initialization.

Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Testsetup seems broken though.

@thet
Copy link
Member Author

thet commented Apr 21, 2023

@fredvd tnx for your fix! since more is needed i created a separate PR and removed your commit from this one to keep it pure: #538

@frapell
Copy link
Sponsor Member

frapell commented Apr 22, 2023

@thet Not sure if I am doing something wrong? I am pulling this branch, and after running yarn install and yarn build:webpack I am still seeing both tinymce being loaded (mosaic's one is a bit smaller though). Am I missing a step or something? (FYI I am simply opening a mosaic in edit mode with 1 richtext tile in it)

image

@mauritsvanrees
Copy link
Sponsor Member

I have rebased on master. That should fix CI.

@thet
Copy link
Member Author

thet commented Apr 22, 2023

@frapell do is this a bare Plone 6.0 with only mosaic installed? Or are any other addons or tinymce plugins involved?

But this PR is about fixing the flaky initialization. Actually loading the TinyMCE editor twice is probably not fixed by this - this is more about the initialization which also happened twice.

@frapell
Copy link
Sponsor Member

frapell commented Apr 22, 2023

@thet yup, fresh buildout.coredev from 6.0 with only mosaic.

Not sure what I need to test though, everything appears to be working ok, except I still see tinymce chunks being loaded twice as reported. But if this fix is unrelated to that, then everything looks fine.

Copy link
Sponsor Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mauritsvanrees mauritsvanrees merged commit 3d573e8 into master Apr 22, 2023
@mauritsvanrees mauritsvanrees deleted the js-correctly-await-tiny branch April 22, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants