-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TinyMCE gets initialized twice #407
Comments
You are probably correct. Those lines are already years old. And it also works on older versions than your latest one?
Thanks!
…On 27 Mar 2018, 16.53 +0300, Franco Pellegrini ***@***.***>, wrote:
Closed #407 via 0e5ce8c135b309d5ce051f399a265d93b80ef3be.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I haven't tested it yet, will do so shortly and if so, will submit a pull request with that stripped away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@datakurre Do you remember why this was needed here?
plone.app.mosaic/src/plone/app/mosaic/browser/static/js/mosaic.tile.js
Line 793 in b93b809
With latest TinyMCE (4.7.6) I'm observing that the toolbar won't open and I would get this error tinymce/tinymce#2655
For what I understand, TinyMCE loads asynchronously (was this not the case with previous versions?) and because of that line 793, a new pattern is created, but without properly cleaning up the previous initialization... even though there is code that should do that in
plone.app.mosaic/src/plone/app/mosaic/browser/static/js/mosaic.tile.js
Line 1013 in b93b809
Commenting out that line 793 solves the issue for me, and clicking on any of the richtext tiles would now show up the toolbar just fine...
Reading those "HACK HACK HACK" on top makes me think that this might have been something for old TinyMCE that is no longer needed, but I'm not sure...
The text was updated successfully, but these errors were encountered: