Display document byline viewlet only to anonymous users #90
Conversation
If permited by the Allow anyone to view 'about' information option in the Security Settings of Site Setup. Refs: plone/Products.CMFPlone#1556
|
@davilima6 @idgserpro @agnogueira @rodfersou please review and comment. next step should be work on solving plone/Products.CMFPlone#668 |
| @@ -71,7 +71,7 @@ def show(self): | |||
| ISecuritySchema, | |||
| prefix='plone', | |||
| ) | |||
| return not self.anonymous or settings.allow_anon_views_about | |||
| return self.anonymous and settings.allow_anon_views_about | |||
There was a problem hiding this comment.
It'd be nice to add a test so we don't get a regression in this important line again. Where do you think it would be the best place?
|
Since we're assuming "byline is metadata, therefore content", won't it get inconsistent UX-wise to have it displayed differently between anon and logged-in states? Besides it may also break themes because an entire block (and its styles) will be missing, so one more thing to beware of... My question being: isn't it less riskier to live with the toolbar redundancy (+1 here) or should we just wait and see if these problems really happen and actually bother users? @agnogueira, @idgserpro: opinions? |
| @@ -71,43 +71,7 @@ def show(self): | |||
| ISecuritySchema, | |||
| prefix='plone', | |||
| ) | |||
| return not self.anonymous or settings.allow_anon_views_about | |||
There was a problem hiding this comment.
Why not showing for non-anonymous too?
Only reason I can think of is, that the some of the information is available in the toolbar too. But is the toolbar also visible for simple members without editing rights? Then we need this viewlet also for them.
There was a problem hiding this comment.
Yes, the clock icon is available to Members.
There was a problem hiding this comment.
@thet well, another proof that the toolbar design was half baked and the removal of the viewlet was a bad idea in the first place; I would prefer to leave the document byline visible for all, but in the past we had some heated discussions as some people simply wanted to get rid of it without thinking on all the unintended consequences. I was trying to move on but, yes, you are right.
IMO the document byline helps to remove the cluttering of the toolbar and there are many regressions caused by its removal.
@davilima6 the clock icon is not solving all cases; see plone/Products.CMFPlone#1575
…ment byline, as this information was not available to anonymous users anyway We need to review if this is available in the current implementation of the toolbar.
Also, clean up the document byline code to remove unnecessary code.