Skip to content

Commit

Permalink
Merge pull request #371 from plone/remove-portal_properties
Browse files Browse the repository at this point in the history
Remove `portal_properties` code.  Remove `plone_tools.properties`.
  • Loading branch information
ale-rt authored Jun 16, 2024
2 parents 8166339 + 6e5c2f8 commit f799405
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 17 deletions.
2 changes: 2 additions & 0 deletions news/125.breaking
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove `portal_properties` code. Remove `plone_tools.properties`.
[maurits]
3 changes: 0 additions & 3 deletions plone/app/layout/globals/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ def catalog():
def membership():
"""The portal_membership tool"""

def properties():
"""The portal_properties tool"""

def types():
"""The portal_types tool"""

Expand Down
5 changes: 0 additions & 5 deletions plone/app/layout/globals/tests/test_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ def test_membership(self):
self.view.membership(), getToolByName(self.folder, "portal_membership")
)

def test_properties(self):
self.assertEqual(
self.view.properties(), getToolByName(self.folder, "portal_properties")
)

def test_types(self):
self.assertEqual(self.view.types(), getToolByName(self.folder, "portal_types"))

Expand Down
4 changes: 0 additions & 4 deletions plone/app/layout/globals/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ def catalog(self):
def membership(self):
return getToolByName(self.context, "portal_membership")

@memoize_contextless
def properties(self):
return getToolByName(self.context, "portal_properties")

@memoize_contextless
def url(self):
return getToolByName(self.context, "portal_url")
Expand Down
4 changes: 0 additions & 4 deletions plone/app/layout/sitemap/tests/test_sitemap.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ def setUp(self):
# wftool._default_chain == 'plone_workflow'
self.wftool.setChainForPortalTypes(["Document"], "simple_publication_workflow")

self.site_properties = getToolByName(
self.portal, "portal_properties"
).site_properties

# setup private content that isn't accessible for anonymous
setRoles(self.portal, TEST_USER_ID, ["Manager"])
self.portal.invokeFactory(id="private", type_name="Document")
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup


version = "4.1.2.dev0"
version = "5.0.0.dev0"

long_description = (
f"{Path('README.rst').read_text()}\n{Path('CHANGES.rst').read_text()}"
Expand Down

0 comments on commit f799405

Please sign in to comment.