Skip to content

Commit

Permalink
Merge pull request #283 from plone/remove-portal-properties-tool
Browse files Browse the repository at this point in the history
No longer check visible_ids on the 'select default page' form.
  • Loading branch information
jensens authored Jun 7, 2024
2 parents 719ee19 + 87bd122 commit a7a5cdd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 4 additions & 0 deletions news/125.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
No longer check ``visible_ids`` on the 'select default page' form.
Usage of ``visible_ids`` was largely removed in Plone 5.0 already, and you cannot change the setting on the portal or the member.
This was using the deprecated ``portal_properties`` tool.
[maurits]
6 changes: 1 addition & 5 deletions plone/app/content/browser/templates/select_default_page.pt
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,13 @@
">
<tal:hasitems define="
n_items python:len(items);
member portal_state/member;
portal_visible_ids context/portal_properties/site_properties/visible_ids|nothing;
member_visible_ids python:member.getProperty('visible_ids', context.portal_memberdata.getProperty('visible_ids'));
"
condition="items"
>
<dl>
<tal:item repeat="item items">
<dt tal:define="
normalized_type python:plone_view.normalizeString(item.portal_type);
item_id python:'(%s)' % item.getId if (portal_visible_ids and member_visible_ids) else '';
">
<input name="objectId"
type="radio"
Expand All @@ -67,7 +63,7 @@
checked python: (n_items==1 or item.getId==cur_page) and 'checked' or None;
"
/>
<label tal:content="string:${item/pretty_title_or_id} $item_id"
<label tal:content="string:${item/pretty_title_or_id}"
tal:attributes="
for item/getId;
class string:contenttype-${normalized_type};
Expand Down

0 comments on commit a7a5cdd

Please sign in to comment.